Fix .equalTo, .endAt, and .startAt filters when used without key. #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- When used without key they contained a spurious comma, since ['a', undefined] == 'a,' != 'a' == ['a']
| BTW: Possibility to do so is in the official documentation e.g.: https://firebase.google.com/docs/reference/js/firebase.database.Reference#equalTo |
| I think this may have been fixed in the v3 branch, could you have a look? If not could you do a PR to my fork and I'll merge it into v3 |
| I can't test it right now, but looking at the code it does seem to be fixed there. When will you release v3 to the NPM repo? |
| Hopefully have an alpha version out soon |
| RC1 out on npm, can confirm this is working. Closing |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
['equalTo', ['a', undefined]].join(':') is 'equalTo:a,' (with comma at the end) and not 'equalTo:a' which would be the result of ['equalTo', ['a']].join(':').