Update data-test locators for preprints to eow rework #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jh27539 commented Jan 5, 2024
felliott reviewed Jan 5, 2024
felliott reviewed Jan 5, 2024
jh27539 commented Jan 5, 2024
jh27539 commented Jan 5, 2024
jh27539 commented Jan 5, 2024
jh27539 force-pushed the feature/data-test-preprints branch from fc3b601 to 071daaf Compare 
| Ditto! |
cslzchen approved these changes Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose
Update our selenium test to match the new Preprint
data-testcss selectors.During testing we discovered a pagination bug ENG-5129 that was failing the preprints moderation workflows. We documented the bug and found a better locator to continue running our moderation tests while we wait for the bug to be resolved.
Summary of Changes
data-testlocatorsReviewer's Actions
git fetch <remote> pull/160/head:feature/data-test-preprintsRun this test using
pytest tests/test_preprints.py -svpytest tests/test_navbar.py -svTesting Changes Moving Forward
N/A
Ticket
https://openscience.atlassian.net/browse/ENG-5046