Update data-test locators for preprints to eow rework

Author: jh27539

pages/preprints.py

@@ -266,14 +266,26 @@ class PreprintDetailPage(GuidBasePage, BasePreprintPage):
  url_base = urljoin(settings.OSF_HOME, '{guid}')
  identity = Locator(
  By.CSS_SELECTOR,
- '[data-analytics-scope="preprints detail page"]',
+ '[data-test-preprint-header]',
  settings.LONG_TIMEOUT,
  )
 
  # This locator needs a data-test-selector from software devs
- title = Locator(By.CSS_SELECTOR, 'h1', settings.LONG_TIMEOUT)
+ title = Locator(
+ By.CSS_SELECTOR, 'h1[data-test-preprint-title]', settings.LONG_TIMEOUT
+ )
+ view_page = Locator(By.ID, 'view-page')
+ views_count = Locator(By.CSS_SELECTOR, '[data-test-view-count]')
+ downloads_count = Locator(By.CSS_SELECTOR, '[data-test-download-count]')
+ download_button = Locator(By.CSS_SELECTOR, '[data-test-download-button]')
+ edit_preprint_button = Locator(By.CSS_SELECTOR, 'div[class="edit-preprint-button"]')
+ default_citation = Locator(By.CSS_SELECTOR, '[data-test-default-citation="apa"]')
+ response_404 = Locator(By.CSS_SELECTOR, 'pre[style]')
+
+ # Locators for the reviews app preprint detail page
  status = Locator(By.CSS_SELECTOR, 'span._status-badge_7ivjq4')
  status_explanation = Locator(By.CSS_SELECTOR, 'div.status-explanation')
+ withdraw_reason = Locator(By.CSS_SELECTOR, '[data-test-withdrawal-justification]')
  make_decision_button = Locator(
  By.CSS_SELECTOR, 'button.btn.dropdown-toggle.btn-success'
  )
@@ -282,19 +294,11 @@ class PreprintDetailPage(GuidBasePage, BasePreprintPage):
  withdraw_radio_button = Locator(By.CSS_SELECTOR, 'input[value="withdrawn"]')
  reason_textarea = Locator(By.CSS_SELECTOR, 'textarea.form-control.ember-text-area')
  submit_decision_button = Locator(By.ID, 'submit-btn')
- view_page = Locator(By.ID, 'view-page')
- views_downloads_counts = Locator(
- By.CSS_SELECTOR, 'div.share-row.p-sm.osf-box-lt.clearfix > div'
- )
- download_button = Locator(
- By.CSS_SELECTOR, 'div.share-row.p-sm.osf-box-lt.clearfix > a'
- )
- edit_preprint_button = Locator(By.CSS_SELECTOR, 'div[class="edit-preprint-button"]')
 
  # Group Locators
  subjects = GroupLocator(
  By.CSS_SELECTOR,
- '#view-page > div.container > div > div.col-md-5 > div:nth-child(6) > span',
+ '[class="subject-preview"]',
  )
  tags = GroupLocator(By.CSS_SELECTOR, 'div.tag-section.p-t-xs > span')
 

tests/test_preprints.py

@@ -489,8 +489,6 @@ def test_reject_pre_moderated_preprint(
  page_not_found_page = PreprintPageNotFoundPage(driver, verify=True)
  assert page_not_found_page.page_header.text == 'Page not found'
 
- @pytest.mark.skip
- # skip until bug is fixed [ENG-5055]
  def test_approve_withdrawal_request_pre_moderated_preprint(
  self, session, driver, log_in_if_not_already
  ):
@@ -582,9 +580,8 @@ def test_approve_withdrawal_request_pre_moderated_preprint(
  assert PreprintDetailPage(driver, verify=True)
  WebDriverWait(driver, 5).until(EC.visibility_of(preprint_page.title))
  assert preprint_page.title.text == preprint_title
- assert (
- preprint_page.status_explanation.text == 'This preprint has been withdrawn.'
- )
+ # Add assert for "This preprint has been withdrawn" after [ENG-5092] is fixed.
+ assert preprint_page.withdraw_reason.present()
 
  def test_decline_withdrawal_request_pre_moderated_preprint(
  self, session, driver, log_in_if_not_already
@@ -763,8 +760,6 @@ def test_accept_post_moderated_preprint(
  assert preprint_page.title.text == preprint_title
  assert provider_id in driver.current_url
 
- @pytest.mark.skip
- # Skip until bug is fixed [ENG-5055]
  def test_moderator_withdrawal_post_moderated_preprint(
  self, session, driver, log_in_if_not_already
  ):
@@ -849,12 +844,9 @@ def test_moderator_withdrawal_post_moderated_preprint(
  assert PreprintDetailPage(driver, verify=True)
  WebDriverWait(driver, 5).until(EC.visibility_of(preprint_page.title))
  assert preprint_page.title.text == preprint_title
- assert (
- preprint_page.status_explanation.text == 'This preprint has been withdrawn.'
- )
+ # Add assert for "This preprint has been withdrawn" after [ENG-5092] is fixed.
+ assert preprint_page.withdraw_reason.present()
 
- @pytest.mark.skip
- # Skip until bug is fixed [ENG-5055]
  def test_approve_withdrawal_request_post_moderated_preprint(
  self, session, driver, log_in_if_not_already
  ):
@@ -946,9 +938,8 @@ def test_approve_withdrawal_request_post_moderated_preprint(
  assert PreprintDetailPage(driver, verify=True)
  WebDriverWait(driver, 5).until(EC.visibility_of(preprint_page.title))
  assert preprint_page.title.text == preprint_title
- assert (
- preprint_page.status_explanation.text == 'This preprint has been withdrawn.'
- )
+ # Add assert for "This preprint has been withdrawn" after [ENG-5092] is fixed.
+ assert preprint_page.withdraw_reason.present()
 
  def test_decline_withdrawal_request_post_moderated_preprint(
  self, session, driver, log_in_if_not_already
@@ -1089,8 +1080,6 @@ def test_preprint_detail_page(self, driver):
 
 @markers.smoke_test
 @markers.core_functionality
-@pytest.mark.skip
-# skip until we have reliable data test locators [ENG-5046]
 class TestPreprintMetrics:
  @pytest.fixture(scope='session')
  def latest_preprint_node(self):
@@ -1107,12 +1096,16 @@ def test_preprint_views_count(self, driver, latest_preprint_node):
  preprint_page = PreprintDetailPage(driver, guid=latest_preprint_node)
  preprint_page.goto()
  assert PreprintDetailPage(driver, verify=True)
- match = re.search(
- r'Views: (\d+) \| Downloads:', preprint_page.views_downloads_counts.text
+
+ # Preprint page shows a string on the front end and api returns a non-string value from the db
+ assert preprint_page.views_count.text == str(api_views_count)
+ # Wait for most of the page to finish loading before reloading page
+ WebDriverWait(driver, 10).until(
+ EC.visibility_of(preprint_page.default_citation)
  )
- assert match is not None
- page_views_count = int(match.group(1))
- assert api_views_count == page_views_count
+ # "response 404 (backend NotFound), service rules for the path non-existent"
+ # error message shows when the preprint fails to load
+ assert not preprint_page.response_404
  # Don't reload the page in Production since we don't want to artificially
  # inflate the metrics
  if not settings.PRODUCTION:
@@ -1122,7 +1115,7 @@ def test_preprint_views_count(self, driver, latest_preprint_node):
  # The initial load of the page above adds 1 to the views count, and the
  # following reload adds a 2nd view to the count. But the update to the
  # database can take a couple of seconds, so immediately accessing the api
- # to get the count below may not show the 2nd view.  Hence we are just
+ # to get the count below may not show the 2nd view. Hence, we are just
  # checking that the views count did increase but not by how much.
  # Unfortunately this means that we are not checking for any issues like
  # double-counting.
@@ -1145,10 +1138,7 @@ def test_preprint_downloads_count(self, driver, latest_preprint_node):
  preprint_page = PreprintDetailPage(driver, guid=latest_preprint_node)
  preprint_page.goto()
  assert PreprintDetailPage(driver, verify=True)
- page_downloads_count = int(
- preprint_page.views_downloads_counts.text.split('Downloads:')[1]
- )
- assert api_downloads_count == page_downloads_count
+ assert str(api_downloads_count) == preprint_page.downloads_count.text
  # Don't download the Preprint in Production since we don't want to artificially
  # inflate the metrics
  if not settings.PRODUCTION: