Skip to content

fix(keepalive): fix render error in cached is undefined #11431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(keepalive): fix render error in cached is undefined #11431

wants to merge 1 commit into from

Conversation

yangliguo7
Copy link
Contributor

close #11427
This was referenced Jul 24, 2024
Closed
Closed
@edison1105
Copy link
Member

Could you please add a test case?
@edison1105 edison1105 added the need test The PR has missing test cases. label Jul 30, 2024
@kakkokari-gtyih
Copy link
Contributor

@yangliguo7 Do you plan to add test anytime soon?
@kakkokari-gtyih
Copy link
Contributor

@yangliguo7 Do you plan to add test anytime soon?

If you don't have time to do that, I can cherry-pick your changes, add some tests, and make PR
@kakkokari-gtyih kakkokari-gtyih mentioned this pull request Aug 5, 2024
Merged
@yyx990803 yyx990803 closed this in 81351dc Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

need test The PR has missing test cases.

3 participants

@yangliguo7 @edison1105 @kakkokari-gtyih