Skip to content

fix(keepalive): render fails when cache contains undefined #11496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 7, 2024
Merged

fix(keepalive): render fails when cache contains undefined #11496

merged 5 commits into from
Aug 7, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

@kakkokari-gtyih kakkokari-gtyih commented Aug 5, 2024 •
edited
Loading

What

I cherry-picked changes on #11431 and added test for this issue on top of the existing test case by adding extra conditions.
(Should I add test case separately for this?)

Fix #11427
Close #11431
@edison1105 edison1105 added scope: keep-alive 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews labels Aug 5, 2024
@netlify Netlify
Copy link

netlify bot commented Aug 6, 2024 •
edited
Loading

❌ Deploy Preview for vue-next-template-explorer failed.

Name Link
🔨 Latest commit f8ef733
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/66b24f7496f4fc0009676685
@kakkokari-gtyih
Copy link
Contributor Author

#11496 (comment) seems nothing to do with the content of the PR
@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Aug 6, 2024 •
edited
Loading

Netlify keeps failing... Are there other PRs affected?
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 7, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 90.1 kB (+4 B) 34.6 kB (+2 B) 31.1 kB (+4 B)
vue.global.prod.js 147 kB (+4 B) 54 kB (+2 B) 48 kB (-23 B)

Usages

Name Size Gzip Brotli
createApp 49.6 kB 19.5 kB 17.8 kB
createSSRApp 53.2 kB 21 kB 19.1 kB
defineCustomElement 51.9 kB 20.2 kB 18.5 kB
overall 63.1 kB (+4 B) 24.5 kB (+3 B) 22.3 kB (-30 B)
@yyx990803 yyx990803 merged commit 81351dc into vuejs:main Aug 7, 2024
@kakkokari-gtyih kakkokari-gtyih deleted the fix-11427-0 branch August 7, 2024 04:07
@kakkokari-gtyih kakkokari-gtyih mentioned this pull request Aug 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready for review This PR requires more reviews scope: keep-alive

4 participants

@kakkokari-gtyih @edison1105 @yyx990803 @yangliguo7