feat(bigtable): expose a metric to track the number of outstanding rpcs (unary , streaming) in channel pool #2696
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
sushanb added the kokoro:force-run 
yoshi-kokoro removed the kokoro:force-run product-auto-label bot added size: l sushanb added the kokoro:force-run yoshi-kokoro removed the kokoro:force-run sushanb changed the title 
mutianf reviewed Oct 23, 2025
...oud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/BigtableClientContext.java Outdated Show resolved Hide resolved
...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/ChannelPoolMetricsTracer.java Show resolved Hide resolved
...c/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/OutstandingRpcsMetricTracker.java Outdated Show resolved Hide resolved
...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/ChannelPoolMetricsTracer.java Show resolved Hide resolved
...c/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/OutstandingRpcsMetricTracker.java Outdated Show resolved Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Show resolved Hide resolved
| | ||
| @Override | ||
| public int getOutstandingStreamingRpcs() { | ||
| return 0; |
Contributor
There was a problem hiding this comment.
return outstandingStreamingRpcs.get(); ?
And maybe add a test case? I'm a little concerned that this is not caught by any tests :)
Contributor Author
There was a problem hiding this comment.
no tests for ChannelPool. added a test
...le/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java Show resolved Hide resolved
...e/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/ChannelPoolMetricsTracer.java Show resolved Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java Outdated Show resolved Hide resolved
product-auto-label bot added size: xl mutianf reviewed Oct 27, 2025
| Aggregation.explicitBucketHistogram( | ||
| ImmutableList.of( | ||
| 0.0, 1.0, 2.0, 3.0, 4.0, 5.0, 6.0, 7.0, 8.0, 9.0, 10.0, 12.0, 14.0, 16.0, 18.0, 20.0, | ||
| 25.0, 30.0, 35.0, 40.0, 45.0, 50.0, 60.0, 70.0, 80.0, 90.0, 100.0, 110.0)); // Added |
Contributor
There was a problem hiding this comment.
nit, remove the // Added comment in the end?
Do we need to go over 100? cause the grpc limit is 100.
Also wondering if we should have equal size for the bucket, maybe [0, 2, 4, 6, 8 ..., 100]? or [0, 5, 10, 15 .. 100]?
Contributor Author
There was a problem hiding this comment.
i think the queuing of the stream is deep inside the http2 lib in grpc netty. so we could have more than 100 here.
...loud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelObserver.java Outdated Show resolved Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated Show resolved Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Show resolved Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated Show resolved Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Outdated Show resolved Hide resolved
...able/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableTransportChannelProvider.java Outdated Show resolved Hide resolved
.../src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/ChannelPoolMetricsTracker.java Outdated Show resolved Hide resolved
.../src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/ChannelPoolMetricsTracker.java Outdated Show resolved Hide resolved
...loud-bigtable/src/test/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPoolTest.java Show resolved Hide resolved
mutianf reviewed Oct 29, 2025
| } | ||
| | ||
| void checkAndSetIsAlts(ClientCall<?, ?> call) { | ||
| // TODO(populate ALTS holder) |
Contributor
There was a problem hiding this comment.
nit: do we still need the TODO?
Contributor Author
There was a problem hiding this comment.
Yes, I will add it in another PR. for now, we use false.
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java Show resolved Hide resolved
mutianf approved these changes Oct 29, 2025
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 18, 2025
🤖 I have created a release *beep* *boop* --- ## [2.69.0](https://togithub.com/googleapis/java-bigtable/compare/v2.68.0...v2.69.0) (2025-11-17) ### Features * **bigtable:** Add internal grpc subconnections metric and add outstanding rpcs to INTERNAL_VIEW ([#2700](https://togithub.com/googleapis/java-bigtable/issues/2700)) ([e3e6e99](https://togithub.com/googleapis/java-bigtable/commit/e3e6e993ee197f897c166fb8959755db0cb9c3fc)) * **bigtable:** Expose a metric to track the number of outstanding rpcs (unary , streaming) in channel pool ([#2696](https://togithub.com/googleapis/java-bigtable/issues/2696)) ([140a1ad](https://togithub.com/googleapis/java-bigtable/commit/140a1ad81947da26c1539632ff04748dc3498d69)) * **bigtable:** Populate alts field in channel entry ([#2702](https://togithub.com/googleapis/java-bigtable/issues/2702)) ([1bfb763](https://togithub.com/googleapis/java-bigtable/commit/1bfb763e6e4fb6fe8c808abe5dbd4221d3a632c3)) * Enable ALTS hard bound token in Bigtable w/ direct access ([#2695](https://togithub.com/googleapis/java-bigtable/issues/2695)) ([d12b37d](https://togithub.com/googleapis/java-bigtable/commit/d12b37dacf8712d30be05175828999af74159819)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
expose a metric to track the number of outstanding rpcs (unary , streaming) in channel pool