feat(bigtable): add internal grpc subconnections metric and add outstanding rpcs to INTERNAL_VIEW #2700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
product-auto-label bot added size: m 
mutianf reviewed Oct 30, 2025
| AttributeKey.stringKey("grpc_disconnect_error"); | ||
| static final AttributeKey<String> GRPC_LB_LOCALITY_KEY = | ||
| AttributeKey.stringKey("grpc_lb_locality"); | ||
| static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc_target"); |
Contributor
There was a problem hiding this comment.
I think this should be
Suggested change
| static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc_target"); | |
| static final AttributeKey<String> GRPC_TARGET_KEY = AttributeKey.stringKey("grpc.target"); |
?
| static final AttributeKey<String> GRPC_DISCONNECT_ERROR_KEY = | ||
| AttributeKey.stringKey("grpc_disconnect_error"); | ||
| static final AttributeKey<String> GRPC_LB_LOCALITY_KEY = | ||
| AttributeKey.stringKey("grpc_lb_locality"); |
Contributor
There was a problem hiding this comment.
I think this should be
Suggested change
| AttributeKey.stringKey("grpc_lb_locality"); | |
| AttributeKey.stringKey("grpc.lb.locality"); |
?
Contributor Author
There was a problem hiding this comment.
fixed with the format.
All these attributes go reformatting here.
mutianf approved these changes Oct 31, 2025
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 18, 2025
🤖 I have created a release *beep* *boop* --- ## [2.69.0](https://togithub.com/googleapis/java-bigtable/compare/v2.68.0...v2.69.0) (2025-11-17) ### Features * **bigtable:** Add internal grpc subconnections metric and add outstanding rpcs to INTERNAL_VIEW ([#2700](https://togithub.com/googleapis/java-bigtable/issues/2700)) ([e3e6e99](https://togithub.com/googleapis/java-bigtable/commit/e3e6e993ee197f897c166fb8959755db0cb9c3fc)) * **bigtable:** Expose a metric to track the number of outstanding rpcs (unary , streaming) in channel pool ([#2696](https://togithub.com/googleapis/java-bigtable/issues/2696)) ([140a1ad](https://togithub.com/googleapis/java-bigtable/commit/140a1ad81947da26c1539632ff04748dc3498d69)) * **bigtable:** Populate alts field in channel entry ([#2702](https://togithub.com/googleapis/java-bigtable/issues/2702)) ([1bfb763](https://togithub.com/googleapis/java-bigtable/commit/1bfb763e6e4fb6fe8c808abe5dbd4221d3a632c3)) * Enable ALTS hard bound token in Bigtable w/ direct access ([#2695](https://togithub.com/googleapis/java-bigtable/issues/2695)) ([d12b37d](https://togithub.com/googleapis/java-bigtable/commit/d12b37dacf8712d30be05175828999af74159819)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.