Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Prev Previous commit
Next Next commit
Cleanup - 2.0 typings format, script tags to layout.cshtml
  • Loading branch information
kmkatsma committed Oct 23, 2016
commit fe5059cddf60468e431ce62520783f502f7e56e3
7 changes: 5 additions & 2 deletions templates/AureliaSpa/Views/Home/Index.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,8 @@
ViewData["Title"] = "Home Page";
}



@section scripts {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why the client should be doing 3 separate HTTP requests for these JS files? Couldn't the bootstrap and modules bundles be a single bundle? (Ideally, all the vendor dependencies would be in a single file)

<script type="text/javascript" src="~/dist/aurelia-bootstrap-bundle.js" asp-append-version="true"></script>
<script type="text/javascript" src="~/dist/aurelia-modules-bundle.js"asp-append-version="true"></script>
<script type="text/javascript" src="~/dist/app-bundle.js" asp-append-version="true"></script>
}
4 changes: 1 addition & 3 deletions templates/AureliaSpa/Views/Shared/_Layout.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,7 @@
@RenderBody()

@RenderSection("scripts", required: false)
<script type="text/javascript" src="~/dist/aurelia-bootstrap-bundle.js"></script>
<script type="text/javascript" src="~/dist/aurelia-modules-bundle.js"></script>
<script type="text/javascript" src="~/dist/app-bundle.js"></script>


</body>
</html>
1 change: 1 addition & 0 deletions templates/AureliaSpa/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
}
},
"dependencies": {
"@types/bluebird": "^3.0.35",
"@types/node": "^6.0.45",
"aurelia-bootstrapper-webpack": "^1.0.0",
"aurelia-event-aggregator": "^1.0.0",
Expand Down
2 changes: 1 addition & 1 deletion templates/AureliaSpa/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
"emitDecoratorMetadata": true,
"skipDefaultLibCheck": true,
"lib": [ "es6", "dom" ],
"types": [ "node" ]
"types": [ "node","bluebird" ]
},
"exclude": [ "bin", "node_modules" ],
"atom": { "rewriteTsconfig": false }
Expand Down
5 changes: 0 additions & 5 deletions templates/AureliaSpa/typings.json

This file was deleted.

1 change: 0 additions & 1 deletion templates/AureliaSpa/typings/index.d.ts

This file was deleted.

749 changes: 0 additions & 749 deletions templates/AureliaSpa/typings/modules/bluebird/index.d.ts

This file was deleted.

11 changes: 0 additions & 11 deletions templates/AureliaSpa/typings/modules/bluebird/typings.json

This file was deleted.