Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Add AureliaSpa template #398

Closed
wants to merge 12 commits into from
Closed

Add AureliaSpa template #398

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
600aa17
updates for aurelia
acu-kkatsma Oct 18, 2016
f24fce8
clean up
acu-kkatsma Oct 18, 2016
28c778e
Add typings for node
kmkatsma Oct 22, 2016
1563578
removed local gitignroe
kmkatsma Oct 22, 2016
12120ef
Added in missing _placeholder.txt
kmkatsma Oct 22, 2016
b363ed7
Changes to C# Namespace for uniformity to other templates
kmkatsma Oct 22, 2016
fe5059c
Cleanup - 2.0 typings format, script tags to layout.cshtml
kmkatsma Oct 23, 2016
790b719
First round of code review cleanup
kmkatsma Oct 25, 2016
e8b2ba8
Booting aurelia into a div in Index.cshtml
kmkatsma Oct 26, 2016
5747fb8
HMR workaround applied (seems best "dev experience" for now)
kmkatsma Oct 26, 2016
48a8162
Removed commented line, reverted HMR hack
kmkatsma Oct 26, 2016
68bf670
fixed issues with publish
kmkatsma Oct 28, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clean up
  • Loading branch information
@acu-kkatsma
acu-kkatsma committed Oct 18, 2016
commit f24fce8781beaa8e84738aff07009f20ce178b16
1 change: 0 additions & 1 deletion templates/AureliaSpa/ClientApp/boot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,4 @@ export function configure(aurelia: Aurelia) {
.developmentLogging();
Copy link
Member

@SteveSandersonMS SteveSandersonMS Oct 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you adapt this so that the developmentLogging only happens from dev builds and not from prod builds?
Copy link
Contributor Author

@kmkatsma kmkatsma Oct 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I'll add a check for localhost in window location to decide whether to enable logging. Couldn't find a better suggestion not relying on a gulp task to actually edit code (that's what I've used in past). Only happens when app is loading so doesn't seem too bad.

aurelia.start().then(() => aurelia.setRoot('app/components/app/app'));
console.log('in configure');
}
3 changes: 1 addition & 2 deletions templates/AureliaSpa/project.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,7 @@
"npm install",
"node node_modules/webpack/bin/webpack.js --env.prod"
],
"postpublish": [ "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%",
"node node_modules/webpack/bin/webpack.js --watch" ]
"postpublish": "dotnet publish-iis --publish-folder %publish:OutputPath% --framework %publish:FullTargetFramework%"
},

"tooling": {
Expand Down