[MRG] Codecov options + remove 2.7 #178
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #178 +/- ## ======================================= Coverage 92.21% 92.21% ======================================= Files 15 15 Lines 3007 3007 ======================================= Hits 2773 2773 Misses 234 234 |
| Also, since we moved strictly away from python 2.7, should we remove the |
setup.py Outdated
| 'Topic :: Scientific/Engineering :: Artificial Intelligence', | ||
| 'Topic :: Scientific/Engineering :: Mathematics', | ||
| 'Topic :: Scientific/Engineering :: Information Analysis', | ||
| 'Programming Language :: Python :: 2', |
There was a problem hiding this comment.
Python 2 should be removed
| Yes external should be removed |
| This is probably not the best place to address this, but I think, for PRs, we should always squash the changes rather than merge commit them. This prevents us from logging the whole git history (i.e. minor commits to fix issues addressed by reviewers). By squashing the changes into 1 commit, we only save the history of the changes that matter (i.e. change from the previous pull request). It leaves a much cleaner git history, in my opinion. |
| I disabled "Allow merge commits" in settings … |
| I think there may be some issues with the codecov tool, its not reporting on the coverage correctly. Working on a fix rn |
| It seems that the codecov reports failed to upload properly, I think this error is on codecov's end. See here for full build details. Hopefully, it works correctly on the next commit! |
rflamary changed the title 
| @ayushkarnawat actually you had the wrong path for gpu it is actually ot/gpu/*.py Sorry i did not see that earlier. Right now we are at 88% caverage could you fix that please? |
| Whoops my bad. Sorry for the late reply. Seems like you already fixed it! Thanks for catching it. |
4 participants
What does this PR do?
Instead of specifying the files to ignore within .coveragerc, I believe it is recommended to add those settings inside the
codecov.ymlfile instead.I also removed some unnecessary imports and lines from setup that were no longer used.
As a side note, for now, I have specified that the codecov bot only comments on pull requests whenever there is a change (current behavior), should we set it to comment even if there are no changes to the coverage (recommend by codecov)?