Skip to content

Conversation

@rodriciru
Copy link
Contributor

I try to update this extension to use webpack instead of current build.
Advantages are:

  • Optimized builds
  • Use of Babel
  • Compatibility with browser VS Code editions (NOT TESTED)

Also, I update dependencies, remove unused imports and remove unused VS Code Test Task

*NOTE:
This PR invalidates this PR (#23) because now, Webpack and some babel plugins can handle lodash and make it slim by changing the imports.

But if we don't want Webpack, my old PR is still valid

@lmajano
Copy link
Member

lmajano commented Jun 28, 2023

Wow. This is great. Thanks so much. I am back in office Monday. I will revise it then.

@lmajano
Copy link
Member

lmajano commented Jun 28, 2023

Reviewed, please review the questions. Thanks

@lmajano lmajano merged commit 54df5f4 into ColdBox:master Jun 29, 2023
@lmajano
Copy link
Member

lmajano commented Jun 29, 2023

Thanks so much for assisting. Love it

@rodriciru
Copy link
Contributor Author

My pleasure

@rodriciru rodriciru deleted the webpack branch June 29, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2 participants