Fix lodash not found #23
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #20
This PR fixes that issue, and subsequently, and issue when I cannot get code completion on anything (event, prc, rc....)
Lodash is not found, because in
.vscodeignorefile there's an ignored node_modules folder, so no lodash is bundled, so not found.If you remove that line, the extension works, but then you have a massive big extension because when package a vsix,
vscebundles all libraries required in package.json. That's why I movedconvert-snippets-to-vscodeto devDependencies, uninstall lodash and install lodash per method packages to reduce the bundle size.In my humble opinion, this extension should be bundled whit webpack but literary this is my second time with VS Code extensions