Skip to content

Conversation

@rodriciru
Copy link
Contributor

@rodriciru rodriciru commented Jun 26, 2023

Fixes #20

This PR fixes that issue, and subsequently, and issue when I cannot get code completion on anything (event, prc, rc....)

Lodash is not found, because in .vscodeignore file there's an ignored node_modules folder, so no lodash is bundled, so not found.

If you remove that line, the extension works, but then you have a massive big extension because when package a vsix, vsce bundles all libraries required in package.json. That's why I moved convert-snippets-to-vscode to devDependencies, uninstall lodash and install lodash per method packages to reduce the bundle size.

In my humble opinion, this extension should be bundled whit webpack but literary this is my second time with VS Code extensions

@rodriciru rodriciru mentioned this pull request Jun 27, 2023
@rodriciru
Copy link
Contributor Author

Because the last PR merged, this is now not necessary.
I will close that

@rodriciru rodriciru closed this Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant