Skip to content

Add toggles for backtick, empty, implicit array creation and short ternary #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 24, 2024
Merged

Add toggles for backtick, empty, implicit array creation and short ternary #249

merged 5 commits into from
Sep 24, 2024

Conversation

@ruudk
Copy link
Contributor

@ruudk ruudk commented Sep 24, 2024

Fixes #248
@ruudk ruudk mentioned this pull request Sep 24, 2024
Closed
ondrejmirtes
ondrejmirtes requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also do a separate option for DynamicCallOnStaticMethodsCallableRule and DynamicCallOnStaticMethodsRule, it's been on my todolist for 2.0 :)
@ruudk ruudk requested a review from ondrejmirtes September 24, 2024 11:40
@ruudk
Copy link
Contributor Author

ruudk commented Sep 24, 2024

I made some changes, please have look.
@ondrejmirtes ondrejmirtes merged commit 988fab9 into phpstan:2.0.x Sep 24, 2024
31 checks passed
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Sep 24, 2024

Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@ruudk @ondrejmirtes