vprintf/vsprintf require a non-empty-array argument #3126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| should |
| Your example is misleading: https://3v4l.org/Mvl72 It'd make much more sense to create a rule similar to PrintfParametersRule. |
clxmstaab force-pushed the vprintf branch 2 times, most recently from 08e8aa1 to faf6099 Compare 
staabm commented Jun 4, 2024
staabm commented Jun 5, 2024
ondrejmirtes requested changes Jun 5, 2024
| This pull request has been marked as ready for review. |
staabm force-pushed the vprintf branch 2 times, most recently from ecf35bc to c0ac13c Compare staabm force-pushed the vprintf branch 2 times, most recently from 323ad98 to eb1e62d Compare This was referenced Jun 19, 2024
staabm force-pushed the vprintf branch 2 times, most recently from 6085104 to d14b403 Compare ondrejmirtes requested changes Jul 15, 2024
ondrejmirtes requested changes Jul 17, 2024
There was a problem hiding this comment.
What about handling $placeHoldersCount as IntegerRangeType + $formarArgsCount as ConstantIntegerType?
There was a problem hiding this comment.
if I don't oversee anything, this IF statement here will cover the remaining cases.
I simplified it further.
| This pull request has been marked as ready for review. |
| Thank you. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
these functions throw a ValueError when called with an empty array, see