Refactor PrintfParametersRule #3247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| This pull request has been marked as ready for review. |
staabm commented Jul 16, 2024
Comment on lines +21 to +29
| public function getPrintfPlaceholdersCount(string $format): int | ||
| { | ||
| return $this->getPlaceholdersCount('(?:[bs%s]|l?[cdeEgfFGouxX])', $format); | ||
| } | ||
| | ||
| public function getScanfPlaceholdersCount(string $format): int | ||
| { | ||
| return $this->getPlaceholdersCount('(?:[cdDeEfinosuxX%s]|\[[^\]]+\])', $format); | ||
| } |
There was a problem hiding this comment.
I need this use-cases separated because I only need the getPrintfPlaceholdersCount in PrintfArrayParametersRule
staabm commented Jul 16, 2024
| } | ||
| | ||
| $formatArgumentPosition = $functionsArgumentPositions[$name]; | ||
| $functionReflection = $this->reflectionProvider->getFunction($node->name, $scope); |
There was a problem hiding this comment.
this was one of the few rules which did not validate the $node->name via ReflectionProvider.
I guess its not strictly necessary because we are handling php-src native functions - I added it for consistency.
| Thank you! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
extracted from #3126
factor out
PrintfHelperfor later re-use in a to be createdPrintfArrayParametersRule