Add Input Mode toggle to voice search #7059
Merged
+683 −64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
2 tasks
joshliebe force-pushed the feature/josh/add-toggle-voice branch 17 times, most recently from 9a2847d to 3dd8e18 Compare joshliebe force-pushed the feature/josh/input-mode-common branch from 7d592b5 to 3455705 Compare joshliebe force-pushed the feature/josh/add-toggle-voice branch from 66355df to ca8fccd Compare 
malmstein approved these changes Nov 6, 2025
There was a problem hiding this comment.
Went through the code together with @joshliebe and did all the necessary changes. Great work!
12 tasks
joshliebe force-pushed the feature/josh/input-mode-common branch from 3455705 to 7734047 Compare joshliebe force-pushed the feature/josh/add-toggle-voice branch 4 times, most recently from cfbd040 to 5e67d7e Compare 
# Conflicts: # duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/RealDuckChat.kt # duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/repository/DuckChatFeatureRepository.kt # duckchat/duckchat-impl/src/main/java/com/duckduckgo/duckchat/impl/store/DuckChatDataStore.kt # duckchat/duckchat-impl/src/main/res/values/donottranslate.xml
joshliebe force-pushed the feature/josh/add-toggle-voice branch from f64f0ad to e6491d8 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211841661898284?focus=true
Description
duckAiVoiceSearchfeature toggle set toINTERNALSteps to test this PR
Unfocussed state
Input Screen
Disabled
playDebug
playDebugUI changes