Skip to content

Conversation

@joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Nov 6, 2025

Task/Issue URL: https://app.asana.com/1/137249556945/project/488551667048375/task/1211863634389611?focus=true

Description

  • Adds pixels when completing a voice search using the Input Mode toggle and canceling a voice search

Steps to test this PR

  • Submit a “Search” voice search
  • Verify Pixel sent: m_voice_search_serp_done with params: {source=browser} {}
  • Submit a “Duck.ai” voice search
  • Verify Pixel sent: m_voice_search_aichat_done with params: {source=browser} {}
  • Cancel a voice search
  • Verify Pixel sent: m_voice_search_cancelled with params: {source=browser} {}

Disabled

  • Disable “Voice Search” in “Duck.ai Shortcuts"
  • Go to the Input Screen
  • Submit a “Search” voice search
  • Verify not sent Pixel sent: m_voice_search_serp_done with params: {source=browser} {}
  • Submit a “Duck.ai” voice search
  • Verify not sent Pixel sent: m_voice_search_aichat_done with params: {source=browser} {}
Copy link
Contributor Author

joshliebe commented Nov 6, 2025

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from 4f396d4 to 6b378d5 Compare November 6, 2025 21:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

@joshliebe joshliebe force-pushed the feature/josh/add-toggle-voice branch from fc8a477 to 016fb28 Compare November 6, 2025 23:14
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from 6b378d5 to 178ad88 Compare November 6, 2025 23:14
@joshliebe joshliebe force-pushed the feature/josh/add-toggle-voice branch from 016fb28 to c82c756 Compare November 7, 2025 00:27
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from 178ad88 to 589d44e Compare November 7, 2025 00:28
@joshliebe joshliebe force-pushed the feature/josh/add-toggle-voice branch from c82c756 to cfbd040 Compare November 7, 2025 00:31
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from 589d44e to e18e47a Compare November 7, 2025 00:31
@joshliebe joshliebe force-pushed the feature/josh/add-toggle-voice branch from cfbd040 to 5e67d7e Compare November 7, 2025 01:04
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch 2 times, most recently from b640d3a to f820f7a Compare November 7, 2025 09:26
@joshliebe joshliebe force-pushed the feature/josh/add-toggle-voice branch from f64f0ad to e6491d8 Compare November 7, 2025 10:07
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from f820f7a to 1c95ff8 Compare November 7, 2025 10:07
Base automatically changed from feature/josh/add-toggle-voice to develop November 7, 2025 10:29
@joshliebe joshliebe force-pushed the feature/josh/voice-search-pixels branch from 1c95ff8 to eb9dd08 Compare November 7, 2025 10:29
@joshliebe joshliebe merged commit 9f2a792 into develop Nov 7, 2025
8 checks passed
@joshliebe joshliebe deleted the feature/josh/voice-search-pixels branch November 7, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants