Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

add glossary_id parameter to translate request #39

Closed
wants to merge 1 commit into from
Closed

add glossary_id parameter to translate request #39

wants to merge 1 commit into from

Conversation

@KaiOnGitHub
Copy link

@KaiOnGitHub KaiOnGitHub commented Apr 11, 2022 •
edited
Loading

glossary functionality was added but it seems you couldn't actually use the glossary as the parameter is missing in the translate request. I added the parameter. See https://www.deepl.com/de/docs-api/translating-text/
VimS
VimS suggested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@VimS VimS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Addition of the new Argument in between the already existing Arguments would break functions calls which use the following Arguments like 'splitting_tags' or 'non_splitting_tags'.
The new Argument should be added at the End of the argument list.
@VimS
Copy link
Contributor

VimS commented Apr 27, 2022

Just was that larzuk91 has already done this in his PR:
#37 (review)
@VimS VimS closed this Apr 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants

@KaiOnGitHub @VimS