This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Add PHP 8.1 support #37
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| I finally got a paid API key, all PHPUnit tests passed but one, the one that test against API V1 I hope someone can check/merge my work :) |
VimS suggested changes Apr 27, 2022
There was a problem hiding this comment.
Unfortunately it is not enough to just change the digit in the composer.json
The new php-Version has to be added at least to the travis.yml so tests will be run in a PHP 8.1 environment as well. I will make a new Branch and add your suggestions there along with some other stuff.
| Thank you @VimS |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hello, I'm using this library on a project where we just switched to PHP 8.1. In this PR I'm trying to add support for it. I tried to run the tests but I'm missing a paid API key for the moment. I wonder if this is enough to make this library PHP 8.1 compatible