Fix polygon mode mixin using face as mode #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
| This PR fixes Not-Enough-Crashes compatibility issues. |
Contributor Author
| @xCollateral can you review this please. |
Fox2Code force-pushed the gl_polygon_mode_1028 branch from e27c716 to d96438e Compare Contributor Author
| v2:
|
Contributor Author
| Null check has been replaced by proper implementation: |
Contributor Author
| Note: @xCollateral want to do the commit himself, I keep this PR as a reminder for him. |
artdeell added a commit to WebMobileLauncher/VulkanMod that referenced this pull request Jan 28, 2025
Fix polygon mode mixin using face as mode (xCollateral#516)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix compatibility issue with Not-Enough-Crashes, see: