Skip to content

fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438, #4543) #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438, #4543) #4450

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74f64a4
fix(babel): bust cache when a
LinusBorg Aug 17, 2019
10dcf5c
fix: account for null value in
LinusBorg Aug 17, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion packages/@vue/cli-plugin-babel/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,24 @@ function genTranspileDepRegex (transpileDependencies) {
return deps.length ? new RegExp(deps.join('|')) : null
}

function genTranspiledDepsCacheKey (dependencies = {}, transpileDepRegex) {
if (!transpileDepRegex) return null
return Object
.keys(dependencies)
.reduce((acc, dep) => {
const depPath = path.join('node_modules', dep, '/')
if (transpileDepRegex.test(depPath)) {
acc[dep] = dependencies[dep]
}
return acc
}, {})
}

module.exports = (api, options) => {
const useThreads = process.env.NODE_ENV === 'production' && !!options.parallel
const cliServicePath = require('path').dirname(require.resolve('@vue/cli-service'))
const transpileDepRegex = genTranspileDepRegex(options.transpileDependencies)
const transpiledDependencies = genTranspiledDepsCacheKey(api.service.pkg.dependencies, transpileDepRegex)

api.chainWebpack(webpackConfig => {
webpackConfig.resolveLoader.modules.prepend(path.join(__dirname, 'node_modules'))
Expand Down Expand Up @@ -51,7 +65,8 @@ module.exports = (api, options) => {
'@vue/babel-preset-app': require('@vue/babel-preset-app/package.json').version,
'babel-loader': require('babel-loader/package.json').version,
modern: !!process.env.VUE_CLI_MODERN_BUILD,
browserslist: api.service.pkg.browserslist
browserslist: api.service.pkg.browserslist,
transpiledDependencies
}, [
'babel.config.js',
'.browserslistrc'
Expand Down