Skip to content

fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438, #4543) #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438, #4543) #4450

wants to merge 2 commits into from

Conversation

@LinusBorg
Copy link
Member

@LinusBorg LinusBorg commented Aug 17, 2019 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Underlying tools
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

Other information:

closes #4438
@LinusBorg
fix(babel): bust cache when a
74f64a4 
transpiled dependency's version has changed close #4438
@LinusBorg LinusBorg changed the title fix(babel): bust cache when a fix(babel): bust cache when a transpiled Dependency's version changed Aug 17, 2019
@LinusBorg
Copy link
Member Author

LinusBorg commented Aug 17, 2019 •
edited
Loading

@sodatea

This fix only works when the actual version in package.depencencies has changed.

If the user were to update the dependency in node_modules without reflecting the version bump in package.json, this would fail.

should we get the actual version from the dependency's package.json?
@LinusBorg LinusBorg changed the title fix(babel): bust cache when a transpiled Dependency's version changed fix(babel): bust cache when a transpiled Dependency's version changed [WIP] Aug 17, 2019
@LinusBorg
fix: account for null value in
10dcf5c 
genTranspiledDepsCacheKey
@LinusBorg
Copy link
Member Author

LinusBorg commented Aug 17, 2019

Hm, that failed test works fine locally, I think it's a timeout problem.
@LinusBorg LinusBorg changed the title fix(babel): bust cache when a transpiled Dependency's version changed [WIP] fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438) Sep 5, 2019
@LinusBorg LinusBorg mentioned this pull request Sep 5, 2019
Closed
@LinusBorg LinusBorg changed the title fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438) fix(babel): [WIP] bust cache when a transpiled Dependency's version changed (close #4438, #4543) Sep 5, 2019
@LinusBorg LinusBorg self-assigned this Jan 24, 2020
@LinusBorg LinusBorg closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@LinusBorg