-
- Notifications
You must be signed in to change notification settings - Fork 8.8k
feat(vapor): vapor transition + transition-group #12962
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: minor
Are you sure you want to change the base?
Conversation
… for internal use
…serts during non-hydration (#13220)
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File ( |
41aba70
to 542e401
Compare …y watching props (#13384)
Compiler Changes
Transition
is automatically rewritten asVaporTransition
TransitionGroup
is automatically rewritten asVaporTransitionGroup
Transition
uses thev-if
, the compiler automatically adds a$key
property to the rendering result, making it easier for the runtime to track the element's leaving state using thekey
will be compiled to
Transition
has an explicitkey
, the compiler generates code that includescreateKeyedFragment
, which creates a newDynamicFragment
when thekey
changes, triggering transitionswill be compiled to
appear
is set in theTransition
and the root node usesv-show
, it need to executeapplyVShow
after theTransition
is created to ensure that the appear behavior works properly.will be compiled to
Runtime Changes
VaporTransition
andVaporTransitionGroup
components that reuses most of the logic fromruntime-dom/Transition
Transition
hooks are now stored on theblock.$transition
propertyDynamicFragment
Update Logic Modification:baseResolveTransitionHooks
from the existingresolveTransitionHooks
function to be shared betweenVaporTransition
andTransition
. Each component passes its own specificTransitionHooksContext
Transition
component now supports renderingVapor
componentsTests