Skip to content

fix(runtime-vapor): prevent passing an empty string to classList.add #12974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2025

Conversation

zhiyuanzmj
Copy link
Member

el.classList.add('') // Uncaught SyntaxError: Failed to execute 'add' on 'DOMTokenList': The token provided must not be empty.
Copy link

netlify bot commented Mar 2, 2025

Deploy Preview for vapor-repl ready!

Name Link
🔨 Latest commit 34957eb
🔍 Latest deploy log https://app.netlify.com/sites/vapor-repl/deploys/67d53b5c683b1800085383b1
😎 Deploy Preview https://deploy-preview-12974--vapor-repl.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

pkg-pr-new bot commented Mar 2, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12974 

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12974 

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12974 

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12974 

@vue/compiler-vapor

npm i https://pkg.pr.new/@vue/compiler-vapor@12974 

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12974 

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12974 

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12974 

@vue/runtime-vapor

npm i https://pkg.pr.new/@vue/runtime-vapor@12974 

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12974 

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12974 

vue

npm i https://pkg.pr.new/vue@12974 

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12974 

commit: 34957eb

@edison1105 edison1105 added scope: vapor related to vapor mode ready to merge The PR is ready to be merged. labels Mar 3, 2025
@edison1105 edison1105 merged commit ffb7ba7 into vuejs:vapor Jun 18, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge The PR is ready to be merged. scope: vapor related to vapor mode
3 participants