Make vector icons optional #8
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
patw0929 force-pushed the feature/make-vector-icons-optional branch from 0b315f3 to 2eabe37 Compare 
Owner
| Hi! Thanks for the PR. I was thinking about not having the vector icons dependency (although I cannot imagine an app running without them). I may publish another package to which I would move the logic of this package, without vector icons dependency (ugly overflow button by default). |
Closed
Owner
| so I went ahead with the approach I described in the comment, and there is this new package https://github.com/vonovak/react-navigation-header-buttons-base We'll see how it goes in terms of maintenance, but for now I'll close this PR. Thanks for your effort! |
Author
| Cool, thanks! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Same as
react-native-paper's PR (callstack/react-native-paper#327), we should make thereact-native-vector-iconsoptional.We can use babel-plugin-optional-require to make it happened.