feat: make vector-icons optional. fixes #303 #327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
satya164 force-pushed the @satya164/optional-icon branch 2 times, most recently from 2e4e9d8 to baa83f3 Compare 
satya164 force-pushed the @satya164/optional-icon branch from baa83f3 to bfb5d36 Compare 
thymikee reviewed Apr 18, 2018
src/components/Icon.js Outdated
| const Icon = ({ name, ...props }: Props) => { | ||
| if (typeof name === 'string') { | ||
| return <MaterialIcons {...props} name={name} />; | ||
| return MaterialIcons ? <MaterialIcons {...props} name={name} /> : null; |
Member
There was a problem hiding this comment.
What about adding a warning? Something like:
const error = Error(); // for stack trace error.message = 'Prop "name" was passed to <Icon /> component, but `react-native-vector-icons` is not present in your dependencies. To remove this warning don't pass "name" to <Icon /> or install `react-native-vector-icons`. console.warn(error) satya164 force-pushed the @satya164/optional-icon branch 2 times, most recently from 10cef0b to 39444df Compare satya164 force-pushed the @satya164/optional-icon branch from 39444df to 58f58a8 Compare 
Member
| Awesome DX work @satya164! |
eriveltonelias pushed a commit to eriveltonelias/react-native-paper that referenced this pull request Sep 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.