added circular radius to the circleIconView layer #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…nView frame is set so that custom icons will be masked accordingly to its circular container view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The circular radius allows custom icons to be masked accordingly to its circular container view (and does not interfere or modify with the default icons that are drawn). Two lines added after line 673 in SCLAlertView.swift.
The user would have to set kCircleIconHeight in the SCLAppearance setup, as expected to implement a custom icon for the circleIconView. Setting kCircleIconHeight: CGFloat(56.0) matches the default kCircleHeight and covers the drawn circle. A smaller circle height will allow the drawn circle to show through as a coloured ring, if such an effect is desired.