Skip to content

Draw interposer cuts #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Oct 14, 2025
Merged

Draw interposer cuts #3299

merged 26 commits into from
Oct 14, 2025
+324 −150

Conversation

soheilshahrouz
Copy link
Contributor

This PR updates the graphics code to draw interposer cut lines.
@github-actions github-actions bot added VPR VPR FPGA Placement & Routing Tool libarchfpga Library for handling FPGA Architecture descriptions docs Documentation lang-cpp C/C++ code labels Oct 8, 2025
@soheilshahrouz
Copy link
Contributor Author

Screenshot from 2025-10-08 18-40-18 Screenshot from 2025-10-08 18-40-49 Screenshot from 2025-10-08 18-41-47
AmirhosseinPoolad
AmirhosseinPoolad reviewed Oct 9, 2025
View reviewed changes
Copy link
Contributor

@AmirhosseinPoolad AmirhosseinPoolad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR soheil. Had some minor thoughts, looks good otherwise.
@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz
Could you please take a look at the code and see if it is ready to merge?
vaughnbetz
vaughnbetz requested changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes requested. Also, it seems we should have a control to turn drawing interposer cuts on and off (say in the blocks display panel). What do you think?
@soheilshahrouz soheilshahrouz mentioned this pull request Oct 10, 2025
Open
@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz
I addressed the comments. I think this PR is ready to merge.
vaughnbetz
vaughnbetz requested changes Oct 10, 2025
View reviewed changes
Copy link
Contributor

@vaughnbetz vaughnbetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. A few more nits though ...
@soheilshahrouz
Copy link
Contributor Author

@vaughnbetz Added more details to comments. Should be ready to merge.
@AmirhosseinPoolad AmirhosseinPoolad merged commit 5ce9800 into master Oct 14, 2025
30 checks passed
@AmirhosseinPoolad AmirhosseinPoolad deleted the temp_interposer_cut_dim branch October 14, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation lang-cpp C/C++ code libarchfpga Library for handling FPGA Architecture descriptions VPR VPR FPGA Placement & Routing Tool

3 participants

@soheilshahrouz @vaughnbetz @AmirhosseinPoolad