Skip to content

Conversation

@rluders
Copy link
Collaborator

@rluders rluders commented Jun 29, 2023

Description

Include the property onSlideChange to Carousel component. It will allow users to hook custom behaviors when the slide changes.

Fixes #596

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change contains documentation update

Breaking changes

None.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Existing unit test still passing
  • Manual test (documentation example)

Test Configuration:

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
@vercel
Copy link

vercel bot commented Jun 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flowbite-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 1:44pm
@rluders rluders marked this pull request as ready for review June 29, 2023 13:15
@rluders rluders mentioned this pull request Jun 29, 2023
15 tasks
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7461173) 99.54% compared to head (e63a75f) 99.54%.

Additional details and impacted files
@@ Coverage Diff @@ ## main #833 +/- ## ======================================= Coverage 99.54% 99.54% ======================================= Files 163 163 Lines 6621 6651 +30 Branches 401 410 +9 ======================================= + Hits 6591 6621 +30  Misses 30 30 
Impacted Files Coverage Δ
src/components/Button/Button.tsx 100.00% <100.00%> (ø)
src/components/Button/theme.ts 100.00% <100.00%> (ø)
src/components/Carousel/Carousel.tsx 99.02% <100.00%> (+0.06%) ⬆️
src/components/DarkThemeToggle/DarkThemeToggle.tsx 100.00% <100.00%> (ø)
src/components/Dropdown/Dropdown.tsx 100.00% <100.00%> (ø)
src/components/Navbar/NavbarToggle.tsx 100.00% <100.00%> (ø)
src/components/Sidebar/SidebarItem.tsx 100.00% <100.00%> (ø)
src/components/Sidebar/theme.ts 100.00% <100.00%> (ø)
src/components/TextInput/TextInput.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rluders rluders requested a review from tulup-conner June 29, 2023 19:38
@rluders rluders force-pushed the feat/carousel-onchange branch from 8c70e27 to e63a75f Compare July 3, 2023 13:42
@rluders rluders merged commit c80fb37 into themesberg:main Jul 3, 2023
@tulup-conner
Copy link
Collaborator

Love it

@rafi-medimesh
Copy link

rafi-medimesh commented Nov 8, 2023

@rluders you mean onSlideChange not onChangeSlide, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants