feat(carousel): add onSlide callback #802
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tohiidd force-pushed the feat/carousel-onslide-callback branch from 8b616de to 21edde2 Compare 
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@ ## main #802 +/- ## ======================================= Coverage 99.54% 99.54% ======================================= Files 129 129 Lines 6537 6543 +6 Branches 391 393 +2 ======================================= + Hits 6507 6513 +6 Misses 30 30
☔ View full report in Codecov by Sentry. |
rluders requested changes Jun 15, 2023
| const handleDragging = (dragging: boolean) => () => setIsDragging(dragging); | ||
| | ||
| useEffect(() => { | ||
| !!onSlide && onSlide(activeItem); |
Collaborator
There was a problem hiding this comment.
Why do you add two !!? Isn't just onSlide enough?
Contributor Author
There was a problem hiding this comment.
@rluders !! is not necessary and i just added it for readability sake, i can remove it if you prefer.
Collaborator
There was a problem hiding this comment.
@paghar yes, please make it simplier, just onSlide && onSlide(activeItem) is good.
rluders changed the title 
Collaborator
| Replaced by #833 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Breaking changes
Please document the breaking changes if suitable.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: