Disk encryption and backup disk encryption #94
Closed
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
#49 Clarification around disk encryption and backup disk encryption requirements.
Adding documentation to the README.md and improving the descriptions of the
key_protect_key_crnandbackup_encryption_key_crn.Include some validation on the
backup_encryption_key_crn. This is unlikely to catch much. It does not catch when the value is null andkey_protect_key_crnis substituted. It does not catch when the key is created as part of the root module, since the key is not known until apply time.We can not validate this inside the module, because if the module validates and fails, it becomes impossible to run plan or destroy against the state file. These actions would be required to destroy and recreate the key and/or KP instance.
Types of changes in this PR
No release required
Release required
x.x.X): Change that fixes an issue and is compatible with earlier versions)x.X.x): Change that adds functionality and is compatible with earlier versions)X.x.x): Change that is likely incompatible with previous versions)Release notes content
Add validation to backup_encryption_key_crn to validate backup keys are from us-south/us-east/eu-de.
Checklist for reviewers
Merge actions for mergers
Merge by using "Squash and merge".
Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author.
The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).