fix: cleanup the KMS validation logic + other cleanup

[ocofaigh]

Description

• variable description and validation updates
• member_cpu_count now defaults to 0 (meaning shared CPU)
• removed support for legacy allow listing (use CBRs instead)
• kms_encryption_enabled must now be set if you want to use BYOK or KYOK encryption
• skip_iam_authorization_policy now defaults to true, but is only relevant if kms_encryption_enabled is set to atrue
• some cleanup to pr_test.go and other_test.go
• bump to ibmcloud-terratest-wrapper v1.8.11
• some vars changd from string to number type
• cleaned up some examples

FSCloud profile specific changes:

• backup_encryption_key_crn is no longer a supported variable since it doesn't support HPCS (profile defaults to ICD randonly generated encryption key)
• add crn output
• added variables service_credential_names (to create service credentials) and auto_scaling to enable auto scaling

NOTE: I had to skip the upgrade test due to a bug that is currently in main branch, but is fixed in this PR. I manually ran the complete example (which is used during upgrade test) and it passed

Types of changes in this PR

Changes that affect the core Terraform module or submodules

• Bug fix
• New feature
• Dependency update

Changes that don't affect the core Terraform module or submodules

• Examples or tests (addition or updates of examples or tests)
• Documentation update
• CI-related update (pipeline, etc.)
• Other

Release required?

Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.

• No release
• Patch release (x.x.X)
• Minor release (x.X.x)
• Major release (X.x.x)

Release notes content

• removed incorrect variable validations - validation now handled by provider directly
• several variables have changed from string type to number
• input variable member_cpu_count now supports 0 (meaning shared CPU). This is now the default value, so take note that when updating from a previous version, you may now wish to explicitly set this to match (or update the current value)
• input variable members now has a default value of 2 (was previously 3).
• kms_encryption_enabled must now be set if you want to use BYOK or KYOK encryption
• skip_iam_authorization_policy now defaults to true, but is only relevant if kms_encryption_enabled is set to atrue
• The input variable allowlist has been removed as its now a legacy. The recommendation is to use CBRs instead.

FSCloud profile specific changes:

• backup_encryption_key_crn is no longer a supported variable since it doesn't support HPCS (profile defaults to ICD randomly generated encryption key)
• add crn output
• input variable members now has a default value of 2 (was previously 3).

---

Checklist for reviewers

• If relevant, a test for the change is included or updated with this PR.
• If relevant, documentation for the change is included or updated with this PR.

Merge actions for mergers

• Use a relevant conventional commit message that is based on the PR contents and any release notes provided by the PR author. The commit message determines whether a new version of the module is needed, and if so, which semver increment to use (major, minor, or patch).
• Merge by using "Squash and merge".

[SirSpidey]

👍

[rajatagarwal-ibm]

PR test failing - need to skip upgrade test for this PR

[ocofaigh]

Right, the upgrade test is failing due to a but thats fixed in this PR. Let me locally confirm the "complete" example is working well, and ill push a commit to this PR to skip upgrade test

[terraform-ibm-modules-ops]

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀