i fixed a non working function in my helper

form/form_collections.rst

@@ -752,9 +752,15 @@ the relationship between the removed ``Tag`` and ``Task`` object.
 
  // App\Helper;
  use Doctrine\Common\Collections\ArrayCollection;
-
+ use Doctrine\ORM\EntityManagerInterface;
+
  class Helper 
+ private $em;
 
+ public function __construct(EntityManagerInterface $em)
+ {
+ $this->em = $em;
+ }
  public function backupOriginalEntities($entities)
  {
  $original_entities = new ArrayCollection();
@@ -767,22 +773,16 @@ the relationship between the removed ``Tag`` and ``Task`` object.
  return $original_entities;
  }
 
- //this function removes totally the entity
- public function removeEntity($original_entities, $current_entities)
- {
- foreach ($original_entities as $entity) {
- if (false === $current_entities->contains($entity)) {
- $em->remove($entity);
- }
- }
- }
-
- //this function removes only the relationship
- public function removeRelation($original_entities, $main_entity,$current_entities, $function_name)
+ //this function removes only the relationship, removes the entity if $remove set to true
+ public function removeRelation($original_entities, $main_entity,$current_entities, $function_name, $remove=false)
  { 
  foreach ($original_entities as $entity) {
  if (false === $current_entities->contains($entity)) {
  $main_entity->$function_name($entity);
+
+ if($remove){
+ $this->em->remove($entity);
+ }
  }
  }
  }
@@ -813,12 +813,9 @@ the relationship between the removed ``Tag`` and ``Task`` object.
  if ($editForm->isValid()) {
 
  // remove the relationship between the tag and the Task
- //depending on your needs
- //either
- $helper->removeRelation($original_entities,$event,$task->getTags(),'removeTag');
- //or
- $helper->removeEntity($original_entities,$event,$task->getTags());
-
+ //depending on your needs 
+ $helper->removeRelation($original_entities,$event,$task->getTags(),'removeTag',true); // or let blank if you want to keep orphan
+
  $entityManager->persist($task);
  $entityManager->flush();