Create helper to manage relationship removal #9709
Conversation
I use this in my project. This helper is reusable in any controller and reduce code. I hope you'll find this is a good way to do it and it can be shared with the community :)
There was a problem hiding this comment.
Hello @francebenoit! 👋 Thank you for your first ever contribution to the Symfony documentation. I have added some comments and requested changes. Other people will need to review your pull request to see if this is a good addition to the Symfony documentation.
form/form_collections.rst Outdated
| use Doctrine\ORM\EntityManagerInterface; | ||
| | ||
| class Helper | ||
| private $em; |
There was a problem hiding this comment.
The code indentation is not correct. The build is failing because of this. Can you correct this by using 4 spaces:
class Helper private $em; This also includes other indentation errors in your changes.
form/form_collections.rst Outdated
| You can optionnally reduce the code in your controller and make it reusable to handle other embedded form. | ||
| First create a helper | ||
| | ||
| // App\Helper; |
form/form_collections.rst Outdated
| return $original_entities; | ||
| } | ||
| | ||
| //this function removes only the relationship, removes the entity if $remove set to true |
There was a problem hiding this comment.
There is no space between // and t: // this function removes only [...]
form/form_collections.rst Outdated
| { | ||
| $this->em = $em; | ||
| } | ||
| public function backupOriginalEntities($entities) |
There was a problem hiding this comment.
There is a empty line missing between these functions.
form/form_collections.rst Outdated
| | ||
| if ($editForm->isValid()) { | ||
| | ||
| // remove the relationship between the tag and the Task |
There was a problem hiding this comment.
This comment could be on one line since the second comment line is not correctly styled.
form/form_collections.rst Outdated
| | ||
| // remove the relationship between the tag and the Task | ||
| //depending on your needs | ||
| $helper->removeRelation($original_entities,$event,$task->getTags(),'removeTag',true); // or let blank if you want to keep orphan |
There was a problem hiding this comment.
You can remove the comment on the end and place that to the comment above;
// Remove the relationship between the tag and the Task depending on your needs or let blank if you want to keep orphan
The spelling on this comment is incorrect.
There was a problem hiding this comment.
The build is failing for unexpected indentation:
/home/travis/build/symfony/symfony-docs/form/form_collections.rst:759: ERROR: Unexpected indentation. Could you fix it up @francebenoit?
i fix an indent error. I hope it was the last one !
| @ndench I fix one but iI guess there are more. I'll check the file again and resubmit |
There was a problem hiding this comment.
@ndench I fix one but iI guess there are more. I'll check the file again and resubmit
Thank you @francebenoit. The tests are passed.
| thanks @ndench |
| | ||
| | ||
| Optionnal helper to handle tags removals | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ |
There was a problem hiding this comment.
Please add a blank line after the headline
| .. _`JSFiddle`: http://jsfiddle.net/847Kf/4/ | ||
| .. _`symfony-collection`: https://github.com/ninsuo/symfony-collection | ||
| | ||
| |
There was a problem hiding this comment.
Please remove one blank line
| | ||
| | ||
| | ||
| Optionnal helper to handle tags removals |
There was a problem hiding this comment.
Typo in optional (only 1 n)
| | ||
| Optionnal helper to handle tags removals | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| You can optionnally reduce the code in your controller and make a reusable service to handle all your embedded form. |
There was a problem hiding this comment.
Same typo in optionNaly and only one L
| | ||
| // Create an ArrayCollection of the current objects in the database | ||
| foreach ($entities as $entity) { | ||
| $original_entities->add($entity); |
There was a problem hiding this comment.
Please use cameCase for variable names
| | ||
| First create a helper:: | ||
| | ||
| // src\Helper |
There was a problem hiding this comment.
src/Helper/Helper.php
but we should find a better name than „Helper“
| throw $this->createNotFoundException('No task found for id '.$id); | ||
| } | ||
| $original_entities = $helper->backupOriginalEntities($event->getOrganizationTypes()); |
There was a problem hiding this comment.
$helper and $event is not defined
5 participants
I use this in my project. This helper is reusable in any controller and reduce code.
I hope you'll find this is a good way to do it and it can be shared with the community :)