Skip to content

Conversation

javiereguiluz
Copy link
Member

@javiereguiluz javiereguiluz commented Nov 21, 2017

This was the only remaining article to be updated in "Best Practices".

Related to this:

@weaverryan weaverryan changed the base branch from master to 4.0 November 21, 2017 19:12
@weaverryan
Copy link
Member

@javiereguiluz other PR's are merged now! I've also changed your target branch to 4.0 - but that shouldn't affect you at all (I just don't want to forget to switch on merge)

@weaverryan
Copy link
Member

Thanks Javier! I only made one small change

@weaverryan weaverryan merged commit 175a4e8 into symfony:4.0 Nov 24, 2017
weaverryan added a commit that referenced this pull request Nov 24, 2017
…iluz, weaverryan) This PR was merged into the 4.0 branch. Discussion ---------- Updated the best practice article about config This was the only remaining article to be updated in "Best Practices". Related to this: * The main config.rst is being updated in ~~#8588~~ * Some config/* articles are being updated in ~~#8647~~. * I'm going to update the rest of config/* articles. Commits ------- 175a4e8 minor tweaks b973f0c Updated the best practice article about config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants