Made two more configuration guides flex-ready #8647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wouterj force-pushed the flex/configuration-sub branch from 6e82d96 to fff3c38 Compare 
yceruto reviewed Nov 13, 2017
configuration/environments.rst Outdated
| <import resource="config.xml" /> | ||
| </imports> | ||
| // ... | ||
| $confDir = dirname(__DIR__).'/config'; |
There was a problem hiding this comment.
$this->getProjectDir()? in line with the latest changes symfony/recipes#244.
configuration/environments.rst Outdated
| // app/config/config_benchmark.php | ||
| $loader->import('config_prod.php'); | ||
| // config/benchmark/web_profiler.php |
There was a problem hiding this comment.
config/packages/benchmark/web_profiler.php?
| # .env | ||
| DATABASE_URL="mysql://db_user:db_password@127.0.0.1:3306/db_name?charset=utf8mb4&serverVersion=5.7" | ||
| This variable is referenced in the serivce container configuration using |
javiereguiluz approved these changes Nov 14, 2017
configuration/environments.rst Outdated
| * Loaded in all environments, ``config/packages/framework.yaml`` configures the | ||
| framework with some ``secret`` setting; | ||
| * In the **prod** environment, nothing extra will be set as there is no | ||
| ``config/packages/prod`` directory; |
There was a problem hiding this comment.
config/packages/prod -> config/packages/prod/
wouterj force-pushed the flex/configuration-sub branch from fff3c38 to 70066bf Compare 
wouterj force-pushed the flex/configuration-sub branch from 70066bf to ad4b3a2 Compare 
| Thanks @javiereguiluz @yceruto, fixed all comments you made! |
weaverryan added a commit that referenced this pull request Nov 21, 2017
This PR was merged into the master branch. Discussion ---------- Made two more configuration guides flex-ready Commits ------- ad4b3a2 Made two configuration sub guides flex-ready
weaverryan added a commit that referenced this pull request Nov 24, 2017
…iluz, weaverryan) This PR was merged into the 4.0 branch. Discussion ---------- Updated the best practice article about config This was the only remaining article to be updated in "Best Practices". Related to this: * The main config.rst is being updated in ~~#8588~~ * Some config/* articles are being updated in ~~#8647~~. * I'm going to update the rest of config/* articles. Commits ------- 175a4e8 minor tweaks b973f0c Updated the best practice article about config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.