Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions http_client.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1789,6 +1789,17 @@ You can also pass a set of default options to your client thanks to the

// ...

.. _auto-upgrade-http-version:

.. versionadded:: 7.4

Starting in Symfony 7.4, the option `auto_upgrade_http_version` can
be set to false to disable automatic HTTP protocol version upgrade when
desired.

The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests,
regardless of the option value.
Comment on lines +1799 to +1801
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing this part, I'm not sure it's worth reading/learning

Suggested change
The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests,
regardless of the option value.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have this documented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ajgarlag here. I changed this to a note directive. I know HTTP/1.0 is irrelevant these days, but this is an edge-case that can turn into user confusion and frustration if we don't mention it explicitly. Thanks.


HTTPlug
~~~~~~~

Expand Down Expand Up @@ -1890,6 +1901,9 @@ You can also pass a set of default options to your client thanks to the

// ...


See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version selection works.

Native PHP Streams
~~~~~~~~~~~~~~~~~~

Expand Down