Skip to content

Conversation

ajgarlag
Copy link
Contributor

Fix #21498

http_client.rst Outdated
// ...


See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version upgrade works.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version upgrade works.
See :ref:`auto_upgrade_http_version <auto-upgrade-http-version>` option for details about how the HTTP protocol version selection works.
http_client.rst Outdated

Starting in Symfony 7.4, the option `auto_upgrade_http_version` can
be set to false to disable automatic HTTP protocol version upgrade when
possible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
possible.
desired.
Comment on lines +1799 to +1801

The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests,
regardless of the option value.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing this part, I'm not sure it's worth reading/learning

Suggested change
The automatic HTTP version upgrade is always disabled for HTTP/1.0 requests,
regardless of the option value.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to have this documented.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @ajgarlag here. I changed this to a note directive. I know HTTP/1.0 is irrelevant these days, but this is an edge-case that can turn into user confusion and frustration if we don't mention it explicitly. Thanks.

@javiereguiluz javiereguiluz force-pushed the auto_upgrade_http_version branch from 97d1550 to ac1e0a2 Compare October 15, 2025 06:04
@javiereguiluz javiereguiluz merged commit 606acbb into symfony:7.4 Oct 15, 2025
3 checks passed
@javiereguiluz
Copy link
Member

Thanks Antonio! Your contribution was very nice, but we made some rewords/reformatting while merging.

Specifically, we don't add contents in versionadded directives because they are automatically deleted in upper branches. So, we moved all the content outside and added an example, while keeping the versionadded directive only to mention that this option was introduced in 7.4. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment