-
- Notifications
You must be signed in to change notification settings - Fork 5.3k
English grammar improvements #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits Select commit Hold shift + click to select a range
610f34f grammar fix
cc9f3bd English grammar fix
134f3b4 Clarified introduction to the Controller->forward() example. Not sure…
4090bdb Shortened/clarified password encryption tip
24c2a0b English grammar improvements
56dc3d8 Edited quick_tour/the_architecture.rst via GitHub
b99f53d Edited quick_tour/the_architecture.rst via GitHub
3609838 Edited quick_tour/the_architecture.rst via GitHub
ad1cc0f wrapping and typo
57fdcf6 wrapping fix
c074d5d wrapping
2bbf442 wrapping at 80 columns
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| | @@ -69,7 +69,7 @@ templates. It takes the route name and an array of parameters as arguments and | |
| returns the associated friendly URL. | ||
| | ||
| You can also easily forward the action to another one with the ``forward()`` | ||
| method. As for the ``actions`` helper, it makes an internal sub-request, but | ||
| method. It makes an internal sub-request, but | ||
| it returns the ``Response`` object to allow for further modification:: | ||
| Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You should fix the wrapping here. Author There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you, I will. | ||
| | ||
| $response = $this->forward('AcmeDemoBundle:Hello:fancy', array('name' => $name, 'color' => 'green')); | ||
| | @@ -176,15 +176,15 @@ Moreover, the ``admin`` user has a ``ROLE_ADMIN`` role, which includes the | |
| | ||
| .. tip:: | ||
| | ||
| For readability, passwords are stored in clear in this simple | ||
| configuration, but using any hashing algorithm is a matter of tweaking the | ||
| For readability, passwords are stored in clear text in this simple | ||
| configuration, but you can use any hashing algorithm by tweaking the | ||
| ``encoders`` section. | ||
| | ||
| Going to the ``http://localhost/Symfony/web/app_dev.php/demo/secured/hello`` | ||
| URL will automatically redirect you to the login form as this resource is | ||
| protected by a firewall via a login form. | ||
| URL will automatically redirect you to the login form because this resource is | ||
| protected by a ``firewall``. | ||
| | ||
| You can also force a given role to be required by using the ``@extra:Secure`` | ||
| You can also force the action to require a given role by using the ``@extra:Secure`` | ||
| annotation on the controller:: | ||
| | ||
| /** | ||
| | @@ -198,12 +198,12 @@ annotation on the controller:: | |
| } | ||
| | ||
| Log in as ``user`` and from the secured hello page, click on the "Hello | ||
| resource secured" link; Symfony2 should return a 403 HTTP status code. | ||
| resource secured" link. Symfony2 should return a 403 HTTP status code. | ||
| | ||
| .. note:: | ||
| | ||
| The Symfony2 security layer is very flexible and comes with many different | ||
| user provides (like one for the Doctrine ORM) and authentication providers | ||
| user providers (like one for the Doctrine ORM) and authentication providers | ||
| (like HTTP basic, HTTP digest, or X509 certificates). Read the | ||
| "`Security`_" chapter of the book for more information on how to use and | ||
| configure them. | ||
| | @@ -230,23 +230,23 @@ In this example, the resource will be cached for a day. But you can also use | |
| validation instead of expiration or a combination of both if that fits your | ||
| needs better. | ||
| | ||
| Resource caching is managed by the Symfony2 built-in reverse. But as caching | ||
| is only managed by regular HTTP cache headers, you can also replace it with | ||
| Varnish or Squid and easily scale your application. | ||
| Resource caching is managed by the Symfony2 built-in reverse proxy. But because | ||
| caching is only managed by regular HTTP cache headers, you can replace the | ||
| built-in reverse proxy with Varnish or Squid and easily scale your application. | ||
| | ||
| .. note:: | ||
| | ||
| But what if you cannot cache whole pages? Symfony2 still has the solution | ||
| via Edge Side Includes (ESI) that are supported natively. Learn more by | ||
| via Edge Side Includes (ESI) which are supported natively. Learn more by | ||
| reading the "`HTTP Cache`_" chapter of the book. | ||
| | ||
| Final Thoughts | ||
| -------------- | ||
| | ||
| That's all there is to it, and I'm not even sure we have spent the allocated | ||
| 10 minutes. We briefly introduced bundles in the first part; and all the | ||
| features we've learned about until now are part of the core framework bundle. | ||
| But thanks to bundles, everything can be extended or replaced in Symfony2. | ||
| features we've learned about so far are part of the core framework bundle. | ||
| But thanks to bundles, everything in Symfony2 can be extended or replaced. | ||
| That's the topic of the next part of this tutorial. | ||
| | ||
| .. _Security: http://symfony.com/doc/2.0/book/security/index.html | ||
| | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to wrap the line