English grammar improvements #199
Conversation
… what "As for the ``actions`` helper," meant.
quick_tour/the_big_picture.rst Outdated
| OK I think I did the fixing right? |
| sorry sorry, total git and github newbie! |
quick_tour/the_architecture.rst Outdated
There was a problem hiding this comment.
The wrapping of this paragraph is too short by looking. the rule is to use 72 characters, not 62
There was a problem hiding this comment.
Sorry my editor defaulted to that; I will fix it. I was guessing it was 80 characters...
There was a problem hiding this comment.
Wrapping at 72 was much shorter than the original so I use 80 characters to make it match. I can wrap everything at 72 if you like.
There was a problem hiding this comment.
@weaverryan told me once that 72 was used in the doc but it is not done by all contributors.
I think it should be documented somewhere and done once in the whole doc to harmonize it if this rule is enforced.
There was a problem hiding this comment.
I'll get clarification, but as I understand it, the rule is (approximately) to put a line break after the first line that crosses the 72nd character. So, line lengths will usually be somewhere between 72 and 78 characters depending on the last word.
There was a problem hiding this comment.
Sounds like a fill-column of 78 for Emacs. Do you want me to rewrap all the paragraphs at that length as part of this pull request?
| Thanks Nathan - very good stuff here. I tweaked a few parts - mostly because your changes highlighted a few areas that were weak and needed a little more drastic improvement. As one of our native English speakers (I'm assuming, since you're in Alaska), I hope to see a few more pull requests from you ;) Thanks! |
| You're welcome, and I hope to contribute more. I'm behind the curve on git but reasonably competent with English, sometimes. I am grateful for Symfony and everything you all do and hope to contribute more. Cheers! |
3 participants
I tidied up a few sentences in the Quick Tour.