Linux: Fix -static-executable and remove swiftImageInspectionShared #34180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
- Remove references to swiftImageInspectionShared on Linux and dont have split libraries between static/non-static linked executables. - -static-executable now links correctly Linux. Note: swift::lookupSymbol() will not work on statically linked executables but this can be worked around by using the https://github.com/swift-server/swift-backtrace package.
Contributor Author
| Please test with following pull request: @swift-ci please test |
This was referenced Oct 5, 2020
compnerd approved these changes Oct 6, 2020
Member
compnerd left a comment
compnerd left a comment There was a problem hiding this comment.
This looks largely like my original change with the addition of a test case!
Contributor Author
| Please test with following pull request: @swift-ci please test |
Contributor
| Build failed |
Contributor
| Build failed |
Contributor Author
| Please test with following pull request: @swift-ci please test |
Contributor Author
| @swift-ci test and merge |
1 similar comment
Contributor Author
| @swift-ci test and merge |
Contributor
| @spevans @compnerd Hiya. It looks like this change may have broken static linking on at least CentOS 7: What should we do here? |
kateinoigakukun added a commit to swiftwasm/swift that referenced this pull request Oct 11, 2020
This change is required by swiftlang#34180
kateinoigakukun added a commit to swiftwasm/swift that referenced this pull request Oct 12, 2020
This change is required by swiftlang#34180
Contributor Author
| @brentdax Could it simply be the case that the The lit script is fairly simple but does include the command check: Which is probably breaking it. However it looks like Btw, is there anyway to CI tests on Centos? |
Contributor Author
| I have opened #34275 to fix this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove references to swiftImageInspectionShared on Linux and dont have
split libraries between static/non-static linked executables.
-static-executable now links correctly Linux.
Note: swift::lookupSymbol() will not work on statically linked
executables but this can be worked around by using the
https://github.com/swift-server/swift-backtrace package.