- Notifications
You must be signed in to change notification settings - Fork 10.6k
Description
| Previous ID | SR-13165 |
| Radar | None |
| Original Reporter | 3405691582 (JIRA User) |
| Type | Task |
| Status | Resolved |
| Resolution | Done |
Additional Detail from JIRA
| Votes | 0 |
| Component/s | |
| Labels | Task |
| Assignee | @spevans |
| Priority | Medium |
md5: 690e563998a653a367ea95c34a707ee2
Issue Description:
stdlib/public/runtime/CMakeLists.txt splits ImageInspectionELF.cpp out from swift_runtime_sources into its own library, swiftImageInspectionShared. There appear to still be references from Errors.cpp in swift_runtime_sources to lookupSymbol in ImageInspectionELF.cpp, which means when SWIFT_BUILD_STATIC_STDLIB, if swiftImageInspectionShared is not referred to, complaints about undefined symbols when lazy binding will occur.
This additional error output fouls up the expectation in a number of unit tests, see pr #32736. This only occurs when SWIFT_BUILD_STATIC_STDLIB. (Specifically, the reference in Errors.cpp is only when SWIFT_SUPPORTS_BACKTRACE_REPORTING too.)
Is making this split truly necessary? I suspect it may not be, but I'd have to do some testing on Linux machines to see what the effect would be. See pr #5394, SR-648.