build: rename libllbuild to the proper liblibllbuild #1005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
compnerd requested review from dmbryson, jakepetroules and owenv as code owners | CC: @drexin |
| @swift-ci please test |
| @swift-ci please test |
| The llbuild executable is rarely used compared to the library, I think we should rename that to something like llbuild-exec or llbuild-tool before renaming the library |
| I agree, that's probably the lower risk approach. |
| Works for me; I'll rename the executable. |
| @swift-ci please test |
jakepetroules approved these changes Aug 7, 2025
| @swift-ci please test |
owenv approved these changes Aug 8, 2025
Because `llbuild` is the executable, we cannot have another target with the name `llbuild` which is the library target. As such, the library is named `libllbuild`. This changes the output name of the library to `liblibllbuild`. This was being overridden which caused some trouble for builds which attempted to skirt the dependencies. As the tool is generally unused, prefer to rename the tool target to `llbuild-tool`, and use `OUTPUT_NAME` to retain the output name. This allows us to have the `libllbuild.a` name for the new `llbuild` target.
| @swift-ci please test |
| @swift-ci please smoke test |
| @swift-ci please smoke test Linux platform |
| @swift-ci please smoke test macOS platform |
| @swift-ci please smoke test |
jakepetroules added a commit to jakepetroules/swift-llbuild that referenced this pull request Aug 30, 2025
…n Windows These were originally added 6 years ago in swiftlang#475 to "Disable incremental linking so llbuild.ilk's don't conflict" because at the time the command line tool and library targets were given the same OUTPUT_NAME, which conflicted. In swiftlang#1005 these targets were given distinct names, so the workaround should no longer be necessary. This helps unblock swiftlang/swift-build#757 because this flag is currently added without regard for the specific compiler driver in use, so the flag might not work based on whether clang-cl.exe or cl.exe vs clang.exe (where it would require a -Xlinker prefix), is used.
jakepetroules added a commit that referenced this pull request Sep 2, 2025
…n Windows These were originally added 6 years ago in #475 to "Disable incremental linking so llbuild.ilk's don't conflict" because at the time the command line tool and library targets were given the same OUTPUT_NAME, which conflicted. In #1005 these targets were given distinct names, so the workaround should no longer be necessary. This helps unblock swiftlang/swift-build#757 because this flag is currently added without regard for the specific compiler driver in use, so the flag might not work based on whether clang-cl.exe or cl.exe vs clang.exe (where it would require a -Xlinker prefix), is used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because
llbuildis the executable, we cannot have another target with the namellbuildwhich is the library target. As such, the library is namedlibllbuild. This changes the output name of the library toliblibllbuild. This was being overridden which caused some trouble for builds which attempted to skirt the dependencies. Rename the output to the proper name.