Revert "[Build] Fix linking of llbuild" #1966
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| @swift-ci please test |
| Can we maybe have a version that works on all systems? Because reverting this breaks local builds for me. |
| Hmm, how are you wiring up the dependency for llbuild to swift-driver? That should work properly because |
| As an aside - we should rename the llbuild targets so that this can be avoided. |
| swiftlang/swift-llbuild#1005 should fix the naming issue |
| Okay - we should not merge this if we merge swiftlang/swift-llbuild#1005 as that renames the library target. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reverts #1965
This fixes the build on Windows