Skip to content

fix: support create type #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 8, 2024
Merged

fix: support create type #118

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f8418b
fix: support `define` stmt
cvng Jan 23, 2024
b1ab67e
fix: statement start token maps
cvng Jan 30, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: support define stmt
  • Loading branch information
@cvng
cvng committed Jan 23, 2024
commit 6f8418bca81e900559291936cda5f940b33e974e
3 changes: 3 additions & 0 deletions crates/codegen/src/get_node_properties.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,6 +630,9 @@ fn custom_handlers(node: &Node) -> TokenStream {
} }
// if its a list, we handle it in the handler for `List`
},
protobuf::ObjectType::ObjectType => {
tokens.push(TokenProperty::from(Token::TypeP));
},
_ => panic!("Unknown DefineStmt {:#?}", n.kind()),
}
},
Expand Down
13 changes: 13 additions & 0 deletions crates/parser/src/codegen.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,19 @@ mod tests {

#[test]
fn test_create_type() {
test_get_node_properties(
"create type type1",
SyntaxKind::DefineStmt,
vec![
TokenProperty::from(SyntaxKind::Create),
TokenProperty::from(SyntaxKind::TypeP),
TokenProperty::from("type1".to_string()),
],
)
}

#[test]
fn test_create_composite_type() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: create type as constitute a composite type
test_get_node_properties(
"create type type1 as (attr1 int4, attr2 bool);",
SyntaxKind::CompositeTypeStmt,
Expand Down