fix: support create type #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
cvng commented Jan 24, 2024
| } | ||
| | ||
| #[test] | ||
| fn test_create_composite_type() { |
There was a problem hiding this comment.
NOTE: create type as constitute a composite type
| @cvng thanks! yes, there are some that do not work yet. I have already created an issue to investigate. if you like, please go ahead and check them. |
cvng commented Jan 30, 2024
| SyntaxToken::Optional(SyntaxKind::Or), | ||
| SyntaxToken::Optional(SyntaxKind::Replace), | ||
| SyntaxToken::Required(SyntaxKind::TypeP), | ||
| SyntaxToken::Required(SyntaxKind::Ident), |
cvng commented Jan 30, 2024
| CREATE TYPE type1; | ||
| CREATE TYPE type1 AS (attr1 int4, attr2 bool); | ||
| CREATE TYPE type1 AS (attr1 int4 COLLATE collation1, attr2 bool); | ||
| /* TODO: CREATE TYPE type1 AS (attr1 int4 COLLATE collation1, attr2 bool); */ SELECT 1; |
There was a problem hiding this comment.
can't get COLLATE to work here, I have tried CollateClause ColumnDef CompositeTypeStmt with no luck
it is obfuscated in the macro stack but we have a hint that it panics in codegen::get_location_internal
cvng commented Jan 30, 2024
| , | ||
| errors: [], | ||
| stmts: [], | ||
| stmts: [ |
| awesome! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
add support for object type in
DefineStmtWhat is the current behavior?
--
What is the new behavior?
--
Additional context
while working on this, I realized there is a few statements that have an AST mismatch from
pg_query:https://github.com/search?q=repo%3Asupabase%2Fpostgres_lsp+%22stmts%3A+%5B%5D%2C%22&type=code
with either: no AST (sometimes expected) or AST with wrong nodes (eg. for
create procedure)@psteinroe lmk if i should try to investigate these ones next