Skip to content

[Merged by Bors] - Deploy default and support custom affinities #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - Deploy default and support custom affinities #649

wants to merge 8 commits into from

Conversation

@razvan
Copy link
Member

@razvan razvan commented Feb 22, 2023 •
edited
Loading

Description

Part of stackabletech/issues#323

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@razvan razvan mentioned this pull request Feb 22, 2023
Closed
@razvan razvan marked this pull request as ready for review February 22, 2023 13:58
@razvan razvan requested a review from sbernauer February 22, 2023 16:57
@razvan razvan self-assigned this Feb 22, 2023
sbernauer
sbernauer reviewed Feb 23, 2023
View reviewed changes
CHANGELOG.md
- Generate OLM bundle ([#645])

[#645]: https://github.com/stackabletech/commons-operator/pull/645
### Changed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think of placing it below Added?
@sbernauer sbernauer self-assigned this Feb 23, 2023
@razvan @sbernauer
Update docs/modules/zookeeper/pages/pod_placement.adoc
473ab15 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@sbernauer sbernauer mentioned this pull request Feb 23, 2023
Closed
7 tasks
@razvan razvan requested a review from sbernauer February 23, 2023 09:04
sbernauer
sbernauer approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % Changelog comment
@razvan
Copy link
Member Author

razvan commented Feb 23, 2023

bors merge
bors bot pushed a commit that referenced this pull request Feb 23, 2023
@razvan
Deploy default and support custom affinities (#649)
bed2fc5 
# Description Part of stackabletech/issues#323
@bors
Copy link
Contributor

bors bot commented Feb 23, 2023

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Deploy default and support custom affinities [Merged by Bors] - Deploy default and support custom affinities Feb 23, 2023
@bors bors bot closed this Feb 23, 2023
@bors bors bot deleted the feat/affinity-2 branch February 23, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/23.4.0

4 participants

@razvan @sbernauer @lfrancke