Skip to content

[Merged by Bors] - Deploy default and support custom affinities #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - Deploy default and support custom affinities #241

wants to merge 6 commits into from

Conversation

@razvan
Copy link
Member

@razvan razvan commented Feb 21, 2023 •
edited by sbernauer
Loading

Description

For stackabletech/issues#323

🟢 CI https://ci.stackable.tech/job/airflow-operator-it-custom/70/

Review Checklist

  • Code contains useful comments
  • CRD change approved (or not applicable)
  • (Integration-)Test cases added (or not applicable)
  • Documentation added (or not applicable)
  • Changelog updated (or not applicable)
  • Cargo.toml only contains references to git tags (not specific commits or branches)
  • Helm chart can be installed and deployed operator works (or not applicable)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information
@razvan razvan mentioned this pull request Feb 21, 2023
Closed
@razvan razvan changed the title Use operator-rs 0.36.0 and add pod affinity. Deploy default and support custom affinities Feb 21, 2023
@razvan razvan marked this pull request as ready for review February 21, 2023 15:03
sbernauer
sbernauer reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far, but the legacy selector migration as well as unit tests are missing
@razvan razvan requested a review from sbernauer February 22, 2023 17:27
sbernauer
sbernauer reviewed Feb 23, 2023
View reviewed changes
razvan and others added 2 commits February 23, 2023 10:36
@razvan
Update tests.
829a2fa
@razvan @sbernauer
Update docs/modules/airflow/pages/pod_placement.adoc
360e554 
Co-authored-by: Sebastian Bernauer <sebastian.bernauer@stackable.de>
@razvan razvan requested a review from sbernauer February 23, 2023 09:37
sbernauer
sbernauer approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@sbernauer sbernauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!
@razvan
Copy link
Member Author

razvan commented Feb 24, 2023

bors merge
bors bot pushed a commit that referenced this pull request Feb 24, 2023
@razvan
Deploy default and support custom affinities (#241)
7eb40a4 
# Description For stackabletech/issues#323 🟢 CI https://ci.stackable.tech/job/airflow-operator-it-custom/70/
@bors
Copy link

bors bot commented Feb 24, 2023

Pull request successfully merged into main.

Build succeeded:
@bors bors bot changed the title Deploy default and support custom affinities [Merged by Bors] - Deploy default and support custom affinities Feb 24, 2023
@bors bors bot closed this Feb 24, 2023
@bors bors bot deleted the feat/affinity branch February 24, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release/23.4.0

4 participants

@razvan @sbernauer @lfrancke