[Merged by Bors] - Change credentials of S3ConnectionSpec to use the common SecretClassVolume struct #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| If it's okay for you i would merge it tomorrow to let people have the time to have an objection? |
| bors r+ |
bors bot pushed a commit that referenced this pull request May 17, 2022
…olume struct (#405) ## Description As discussed today
| Build failed: |
| bors retry |
bors bot pushed a commit that referenced this pull request May 17, 2022
…olume struct (#405) ## Description As discussed today
| Build failed: |
| bors r+ |
| bors cancel |
| Canceled. |
| bors r+ |
bors bot pushed a commit that referenced this pull request May 17, 2022
…olume struct (#405) ## Description As discussed today
| Pull request successfully merged into main. Build succeeded: |
bors bot changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
As discussed today
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information