-
-
Couldn't load subscription status.
- Fork 7
[Merged by Bors] - Deploy default and support custom affinities #557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A changelog entry is missing and probably an integration test.
Cargo.toml Outdated
| "rust/crd", "rust/operator", "rust/operator-binary" | ||
| ] | ||
| | ||
| [patch."https://github.com/stackabletech/operator-rs.git"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder to update this file before merging.
| Regarding kuttl test: All we would do is assert on some field (affinity) on the scheduled Pod. |
| I'm fine with only unit testing it but we are missing actual tests for user defined affinities. Only two cases are covered:
|
| The merge mechanism with custom user provided affinities is tested here https://github.com/stackabletech/operator-rs/blob/5aab38f9cdd96b98f483ee3834a9cc74d002c0f0/src/commons/affinities.rs#L160 |
| The defaults and legacy behavior is operator-specific |
| bors merge |
# Description For stackabletech/issues#323 Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com>
| Pull request successfully merged into main. Build succeeded: |
| Added to the Feature Tracker |
| Thx for adding the docs! |
Description
For stackabletech/issues#323
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information